-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove jupyterlab v3 pin #81
Open
kushalkolar
wants to merge
15
commits into
vispy:main
Choose a base branch
from
kushalkolar:jupyterlab-v4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove jupyterlab v4 pin
yarn errors, I will do this later |
* add buttons to wheel event * Add time_stamp to events * update event spec * Fix buttons for wheel event.
* feat: avoid base64-encoding image data * fix: use correct mimetype * fix: remove remaining 'b64_encoding_sum' stats * chore: remove unused imports * ci: bump node version * Tiny refactor to put objectURL calls together. * Can do both * Turn websocket on by default * Fix test and add test for websocket use * flake --------- Co-authored-by: Almar Klein <[email protected]>
* allow setting the cursor * specify TraitError in test (vispy#85)
* Use tuples for buttons and modifiers (instead of list) * add comment * black
remove jupyterlab v4 pin
* Restore version of js module * fix ci and avoid yarn warnings * fix that local / ci need different dev deps
…r_rfb into jupyterlab-v4
this is working now 🥳 , @almarklein ready to go! |
I think this needs a merge with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove jupyterlab v4 pin, allow v3 and v4 for now.