Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite build --watch breaks from 4.1.4 -> 4.2.0 #12791

Closed
7 tasks done
atomkirk opened this issue Apr 7, 2023 · 4 comments · Fixed by #12797
Closed
7 tasks done

vite build --watch breaks from 4.1.4 -> 4.2.0 #12791

atomkirk opened this issue Apr 7, 2023 · 4 comments · Fixed by #12797
Assignees
Labels
p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release

Comments

@atomkirk
Copy link

atomkirk commented Apr 7, 2023

Describe the bug

My relatively new app was using 4.1 and when I removed my package-lock and npm i, it installed 4.2 and vite build --watch no longer works. It will successfully build initially, but then when you change a file it just says build started... and then hangs forever.

Reproduction

https://share.cleanshot.com/vJgtKYvFT9S1gG7vCJZG

Steps to reproduce

This person has also seen the problem recently

https://share.cleanshot.com/vJgtKYvFT9S1gG7vCJZG

System Info

System:
    OS: macOS 12.2.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 1.23 GB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.1 - ~/.asdf/installs/nodejs/16.13.1/bin/node
    npm: 8.1.2 - ~/.asdf/plugins/nodejs/shims/npm
    Watchman: 2023.01.30.00 - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 111.0.5563.146
    Firefox: 101.0.1
    Safari: 15.3

Used Package Manager

npm

Logs

> @jump/[email protected] build:vite:watch
> vite build --watch

vite v4.1.4 building for production...

watching for file changes...

build started...
✓ 604 modules transformed.
dist/react-component-library.cjs  23.97 kB │ gzip: 8.72 kB
dist/react-component-library.es.js  35.01 kB │ gzip: 10.03 kB
built in 543ms.

[vite:dts] Start generate declaration files...
[vite:dts] Declaration files built in 1818ms.


build started...

Validations

@bluwy
Copy link
Member

bluwy commented Apr 8, 2023

A reproduction is not a screenshot. Please provide a stackblitz link or GitHub repo. I can't reproduce it manually on my end.

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Hello @atomkirk. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

@marcoborsoi
Copy link

marcoborsoi commented Apr 8, 2023

Hello @atomkirk @bluwy . I am facing the same issue.
In my case, the build watch gets stuck when using a particular dependency: json-rte-serializer

I opened an issue on their repository: contentstack/json-rte-serializer#23

Here's the link to reproduce:

Reproduction

https://stackblitz.com/edit/vitejs-vite-jxfzwy?file=src/index.ts

Steps to reproduce

  1. npm run dev
  2. Modify the string inside console.log and save
  3. Uncomment the code containing jsonToHtml and save
  4. Modify the string inside console.log again and save

Packages versions

@contentstack/json-rte-serializer:  2.0.2
typescript: 4.9.3
vite: 4.2.1

@bluwy
Copy link
Member

bluwy commented Apr 9, 2023

Thanks for the repro. It looks like a regression from #11919

@bluwy bluwy added p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release and removed needs reproduction labels Apr 9, 2023
@volta-net volta-net bot assigned bluwy Apr 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants