fix sizegen so it handles type aliases (#16650)

Signed-off-by: Andres Taylor <[email protected]>
vitessio · Aug 26, 2024 · 05cdfbb · 05cdfbb
1 parent e6843dc
commit 05cdfbb
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 52 deletions.
diff --git a/go/mysql/collations/colldata/cached_size.go b/go/mysql/collations/colldata/cached_size.go
diff --git a/go/sqltypes/cached_size.go b/go/sqltypes/cached_size.go
diff --git a/go/tools/sizegen/sizegen.go b/go/tools/sizegen/sizegen.go
@@ -149,14 +149,23 @@ func (sizegen *sizegen) generateType(pkg *types.Package, file *codeFile, named *
 	case *types.Interface:
 		findImplementations(pkg.Scope(), tt, func(tt types.Type) {
 			if _, isStruct := tt.Underlying().(*types.Struct); isStruct {
-				sizegen.generateKnownType(tt.(*types.Named))
+				sizegen.generateTyp(tt)
 			}
 		})
 	default:
 		// no-op
 	}
 }
 
+func (sizegen *sizegen) generateTyp(tt types.Type) {
+	switch tt := tt.(type) {
+	case *types.Named:
+		sizegen.generateKnownType(tt)
+	case *types.Alias:
+		sizegen.generateTyp(types.Unalias(tt))
+	}
+}
+
 func (sizegen *sizegen) generateKnownType(named *types.Named) {
 	pkgInfo := named.Obj().Pkg()
 	file := sizegen.codegen[pkgInfo.Path()]

diff --git a/go/vt/proto/query/cached_size.go b/go/vt/proto/query/cached_size.go
diff --git a/go/vt/proto/topodata/cached_size.go b/go/vt/proto/topodata/cached_size.go
diff --git a/go/vt/proto/vttime/cached_size.go b/go/vt/proto/vttime/cached_size.go