Flip logic so vtctlclient continues to work

Signed-off-by: Matt Lord <[email protected]>

go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go

@@ -69,7 +69,7 @@ var (
 		WaitUpdateInterval          time.Duration
 		AutoRetry                   bool
 		MaxDiffDuration             time.Duration
-		AutoStart                   bool
+		DoNotStart                  bool
 	}{}
 
 	deleteOptions = struct {
@@ -297,7 +297,7 @@ func commandCreate(cmd *cobra.Command, args []string) error {
 		AutoRetry:                   createOptions.AutoRetry,
 		MaxReportSampleRows:         createOptions.MaxReportSampleRows,
 		MaxDiffDuration:             protoutil.DurationToProto(createOptions.MaxDiffDuration),
-		AutoStart:                   createOptions.AutoStart,
+		DoNotStart:                  createOptions.DoNotStart,
 	})
 
 	if err != nil {
@@ -891,7 +891,7 @@ func registerCommands(root *cobra.Command) {
 	create.Flags().BoolVar(&createOptions.AutoRetry, "auto-retry", true, "Should this vdiff automatically retry and continue in case of recoverable errors.")
 	create.Flags().BoolVar(&createOptions.UpdateTableStats, "update-table-stats", false, "Update the table statistics, using ANALYZE TABLE, on each table involved in the VDiff during initialization. This will ensure that progress estimates are as accurate as possible -- but it does involve locks and can potentially impact query processing on the target keyspace.")
 	create.Flags().DurationVar(&createOptions.MaxDiffDuration, "max-diff-duration", 0, "How long should an individual table diff run before being stopped and restarted in order to lessen the impact on tablets due to holding open database snapshots for long periods of time (0 is the default and means no time limit).")
-	create.Flags().BoolVar(&createOptions.AutoStart, "auto-start", true, "Start the vdiff upon creation. When false, the vdiff will be created but will not run until resumed.")
+	create.Flags().BoolVar(&createOptions.DoNotStart, "do-not-start", false, "Don't start the vdiff upon creation. When specified, the vdiff will be created but will not run until resumed.")
 	base.AddCommand(create)
 
 	base.AddCommand(delete)

go/vt/vtctl/workflow/server.go

@@ -1785,7 +1785,7 @@ func (s *Server) VDiffCreate(ctx context.Context, req *vtctldatapb.VDiffCreateRe
 	span.Annotate("tables", req.Tables)
 	span.Annotate("auto_retry", req.AutoRetry)
 	span.Annotate("max_diff_duration", req.MaxDiffDuration)
-	span.Annotate("auto_start", req.AutoRetry)
+	span.Annotate("do_not_start", req.GetDoNotStart())
 
 	tabletTypesStr := discovery.BuildTabletTypesString(req.TabletTypes, req.TabletSelectionPreference)
 
@@ -1818,7 +1818,7 @@ func (s *Server) VDiffCreate(ctx context.Context, req *vtctldatapb.VDiffCreateRe
 			MaxExtraRowsToCompare: req.MaxExtraRowsToCompare,
 			UpdateTableStats:      req.UpdateTableStats,
 			MaxDiffSeconds:        req.MaxDiffDuration.Seconds,
-			AutoStart:             req.GetAutoStart(),
+			DoNotStart:            req.GetDoNotStart(),
 		},
 		ReportOptions: &tabletmanagerdatapb.VDiffReportOptions{
 			OnlyPks:       req.OnlyPKs,

go/vt/vttablet/tabletmanager/vdiff/action.go

@@ -200,7 +200,7 @@ func (vde *Engine) handleCreateResumeAction(ctx context.Context, dbClient binlog
 			return err
 		}
 		state := PendingState
-		if !options.GetCoreOptions().GetAutoStart() {
+		if options.GetCoreOptions().GetDoNotStart() {
 			state = StoppedState
 		}
 		query, err := sqlparser.ParseAndBind(sqlNewVDiff,

proto/tabletmanagerdata.proto

@@ -669,7 +669,7 @@ message VDiffCoreOptions {
   int64 max_extra_rows_to_compare = 7;
   bool update_table_stats = 8;
   int64 max_diff_seconds = 9;
-  bool auto_start = 10;
+  bool do_not_start = 10;
 }
 
 message VDiffOptions {

proto/vtctldata.proto

@@ -1862,7 +1862,7 @@ message VDiffCreateRequest {
   bool verbose = 18;
   int64 max_report_sample_rows = 19;
   vttime.Duration max_diff_duration = 20;
-  bool auto_start = 21;
+  bool do_not_start = 21;
 }
 
 message VDiffCreateResponse {