From 3875fd1daf58e43816c090fb00a12b0c142024f4 Mon Sep 17 00:00:00 2001 From: Florent Poinsard Date: Fri, 22 Nov 2024 14:47:38 -0600 Subject: [PATCH] Remove flakiness in tests Signed-off-by: Florent Poinsard --- go/vt/mysqlctl/backup_blackbox_test.go | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/go/vt/mysqlctl/backup_blackbox_test.go b/go/vt/mysqlctl/backup_blackbox_test.go index 2b749bea822..0d5051273aa 100644 --- a/go/vt/mysqlctl/backup_blackbox_test.go +++ b/go/vt/mysqlctl/backup_blackbox_test.go @@ -677,21 +677,11 @@ func TestExecuteBackupFailToWriteEachFileOnlyOnce(t *testing.T) { "Backing up file: test2/0.ibd (attempt 1/2)", "Backing up file: test2/1.ibd (attempt 1/2)", - "Failed backing up \"test1/0.ibd\" (attempt 1/2)", - "Failed backing up \"test1/1.ibd\" (attempt 1/2)", - "Failed backing up \"test2/0.ibd\" (attempt 1/2)", - "Failed backing up \"test2/1.ibd\" (attempt 1/2)", - "Backing up file: test1/0.ibd (attempt 2/2)", "Backing up file: test1/1.ibd (attempt 2/2)", "Backing up file: test2/0.ibd (attempt 2/2)", "Backing up file: test2/1.ibd (attempt 2/2)", - "Completed backing up \"test1/0.ibd\" (attempt 2/2)", - "Completed backing up \"test1/1.ibd\" (attempt 2/2)", - "Completed backing up \"test2/0.ibd\" (attempt 2/2)", - "Completed backing up \"test2/1.ibd\" (attempt 2/2)", - "Backing up file MANIFEST (attempt 1/2)", "Failed backing up MANIFEST (attempt 1/2)", "Backing up file MANIFEST (attempt 2/2)", @@ -744,8 +734,8 @@ func TestExecuteBackupFailToWriteFileEachTwice(t *testing.T) { }, bh) expectedLogs := []string{ - "Failed backing up \"test1/0.ibd\" (attempt 1/2)", - "Failed backing up \"test1/0.ibd\" (attempt 2/2)", + "Backing up file: test1/0.ibd (attempt 1/2)", + "Backing up file: test1/0.ibd (attempt 2/2)", } assertLogs(t, expectedLogs, logger)