Skip to content

Commit

Permalink
feat: fix vtgate crash in group concat
Browse files Browse the repository at this point in the history
Signed-off-by: Manan Gupta <[email protected]>
  • Loading branch information
GuptaManan100 committed Jun 24, 2024
1 parent e8da04f commit 61ba53d
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ func (ab *aggBuilder) handleAggr(ctx *plancontext.PlanningContext, aggr Aggr) er
case opcode.AggregateGroupConcat:
f := aggr.Func.(*sqlparser.GroupConcatExpr)
if f.Distinct || len(f.OrderBy) > 0 || f.Separator != "" {
panic("fail here")
panic(vterrors.VT12001("cannot evaluate group concat with distinct, order by or a separator"))
}
// this needs special handling, currently aborting the push of function
// and later will try pushing the column instead.
Expand Down

0 comments on commit 61ba53d

Please sign in to comment.