From 61ba53d48d3bfbc4f3b4ab01b3b96a458de0eb94 Mon Sep 17 00:00:00 2001 From: Manan Gupta Date: Mon, 24 Jun 2024 15:24:11 +0530 Subject: [PATCH] feat: fix vtgate crash in group concat Signed-off-by: Manan Gupta --- .../vtgate/planbuilder/operators/aggregation_pushing_helper.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/vt/vtgate/planbuilder/operators/aggregation_pushing_helper.go b/go/vt/vtgate/planbuilder/operators/aggregation_pushing_helper.go index eb14f83b7df..7b9cd8518fd 100644 --- a/go/vt/vtgate/planbuilder/operators/aggregation_pushing_helper.go +++ b/go/vt/vtgate/planbuilder/operators/aggregation_pushing_helper.go @@ -135,7 +135,7 @@ func (ab *aggBuilder) handleAggr(ctx *plancontext.PlanningContext, aggr Aggr) er case opcode.AggregateGroupConcat: f := aggr.Func.(*sqlparser.GroupConcatExpr) if f.Distinct || len(f.OrderBy) > 0 || f.Separator != "" { - panic("fail here") + panic(vterrors.VT12001("cannot evaluate group concat with distinct, order by or a separator")) } // this needs special handling, currently aborting the push of function // and later will try pushing the column instead.