From e598a879d903fd8dfa4c852cc68c424481dc74a2 Mon Sep 17 00:00:00 2001
From: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Date: Tue, 22 Oct 2024 16:16:30 +0530
Subject: [PATCH] Remove mysql parameters from VTOrc setup (#16996)

Signed-off-by: Manan Gupta <manan@planetscale.com>
---
 config/vtorc/default.json                 | 4 ----
 examples/common/vtorc/config.json         | 4 ----
 examples/compose/vtorc-up.sh              | 4 ----
 examples/compose/vtorc/default.json       | 4 ----
 go/test/endtoend/cluster/vtorc_process.go | 8 --------
 5 files changed, 24 deletions(-)

diff --git a/config/vtorc/default.json b/config/vtorc/default.json
index 8fc7ab3747d..0a234473d32 100644
--- a/config/vtorc/default.json
+++ b/config/vtorc/default.json
@@ -1,8 +1,4 @@
 {
   "Debug": true,
-  "MySQLTopologyUser": "orc_client_user",
-  "MySQLTopologyPassword": "orc_client_user_password",
-  "MySQLReplicaUser": "vt_repl",
-  "MySQLReplicaPassword": "",
   "RecoveryPeriodBlockSeconds": 5
 }
diff --git a/examples/common/vtorc/config.json b/examples/common/vtorc/config.json
index e1f27ee5762..53b012c2162 100644
--- a/examples/common/vtorc/config.json
+++ b/examples/common/vtorc/config.json
@@ -1,8 +1,4 @@
 {
-  "MySQLTopologyUser": "orc_client_user",
-  "MySQLTopologyPassword": "orc_client_user_password",
-  "MySQLReplicaUser": "vt_repl",
-  "MySQLReplicaPassword": "",
   "RecoveryPeriodBlockSeconds": 1,
   "InstancePollSeconds": 1
 }
\ No newline at end of file
diff --git a/examples/compose/vtorc-up.sh b/examples/compose/vtorc-up.sh
index 7a7394dfc86..a4b03ede7d0 100755
--- a/examples/compose/vtorc-up.sh
+++ b/examples/compose/vtorc-up.sh
@@ -27,10 +27,6 @@ if [ $external = 1 ] ; then
     # This can be overridden by passing VTORC_CONFIG env variable
     echo "Updating $config..."
     cp /vt/vtorc/default.json /vt/vtorc/tmp.json
-    sed  -i '/MySQLTopologyUser/c\  \"MySQLTopologyUser\" : \"'"$DB_USER"'\",' /vt/vtorc/tmp.json
-    sed  -i '/MySQLTopologyPassword/c\  \"MySQLTopologyPassword\" : \"'"$DB_PASS"'\",' /vt/vtorc/tmp.json
-    sed  -i '/MySQLReplicaUser/c\  \"MySQLReplicaUser\" : \"'"$DB_USER"'\",' /vt/vtorc/tmp.json
-    sed  -i '/MySQLReplicaPassword/c\  \"MySQLReplicaPassword\" : \"'"$DB_PASS"'\",' /vt/vtorc/tmp.json
     cat /vt/vtorc/tmp.json
     cp /vt/vtorc/tmp.json /vt/vtorc/config.json
 else
diff --git a/examples/compose/vtorc/default.json b/examples/compose/vtorc/default.json
index e0a03884c99..58513568044 100644
--- a/examples/compose/vtorc/default.json
+++ b/examples/compose/vtorc/default.json
@@ -1,10 +1,6 @@
 {
   "Debug": true,
   "EnableSyslog": false,
-  "MySQLTopologyUser": "orc_client_user",
-  "MySQLTopologyPassword": "orc_client_user_password",
-  "MySQLReplicaUser": "vt_repl",
-  "MySQLReplicaPassword": "",
   "BackendDB": "sqlite",
   "SQLite3DataFile": "/tmp/vtorc.sqlite3",
   "RecoverMasterClusterFilters": ["*"],
diff --git a/go/test/endtoend/cluster/vtorc_process.go b/go/test/endtoend/cluster/vtorc_process.go
index 31cf03606e5..4fcb68e292d 100644
--- a/go/test/endtoend/cluster/vtorc_process.go
+++ b/go/test/endtoend/cluster/vtorc_process.go
@@ -51,10 +51,6 @@ type VTOrcProcess struct {
 type VTOrcConfiguration struct {
 	Debug                                 bool
 	ListenAddress                         string
-	MySQLTopologyUser                     string
-	MySQLTopologyPassword                 string
-	MySQLReplicaUser                      string
-	MySQLReplicaPassword                  string
 	RecoveryPeriodBlockSeconds            int
 	TopologyRefreshSeconds                int    `json:",omitempty"`
 	PreventCrossDataCenterPrimaryFailover bool   `json:",omitempty"`
@@ -71,10 +67,6 @@ func (config *VTOrcConfiguration) ToJSONString() string {
 
 func (config *VTOrcConfiguration) AddDefaults(webPort int) {
 	config.Debug = true
-	config.MySQLTopologyUser = "orc_client_user"
-	config.MySQLTopologyPassword = "orc_client_user_password"
-	config.MySQLReplicaUser = "vt_repl"
-	config.MySQLReplicaPassword = ""
 	if config.RecoveryPeriodBlockSeconds == 0 {
 		config.RecoveryPeriodBlockSeconds = 1
 	}