refactor: clean up join expression logic

Signed-off-by: Andres Taylor <[email protected]>
vitessio · Mar 22, 2024 · f605f62 · f605f62
1 parent c830723
commit f605f62
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/go/vt/vtgate/planbuilder/operators/apply_join.go b/go/vt/vtgate/planbuilder/operators/apply_join.go
@@ -158,6 +158,7 @@ func (aj *ApplyJoin) AddJoinPredicate(ctx *plancontext.PlanningContext, expr sql
 	}
 	col := breakExpressionInLHSandRHSForApplyJoin(ctx, expr, TableID(aj.LHS))
 	aj.JoinPredicates.add(col)
+	ctx.AddJoinPredicates(expr, col.RHSExpr)
 	rhs := aj.RHS.AddPredicate(ctx, col.RHSExpr)
 	aj.RHS = rhs
 }

diff --git a/go/vt/vtgate/planbuilder/operators/expressions.go b/go/vt/vtgate/planbuilder/operators/expressions.go
@@ -51,7 +51,6 @@ func breakExpressionInLHSandRHSForApplyJoin(
 		cursor.Replace(arg)
 	}, nil).(sqlparser.Expr)
 
-	ctx.AddJoinPredicates(expr, rewrittenExpr)
 	col.RHSExpr = rewrittenExpr
 	col.Original = expr
 	return