Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: vttablet parameter doesn't accepts values as described #12719

Closed
Areso opened this issue Mar 23, 2023 · 3 comments
Closed

Bug Report: vttablet parameter doesn't accepts values as described #12719

Areso opened this issue Mar 23, 2023 · 3 comments
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Bug

Comments

@Areso
Copy link

Areso commented Mar 23, 2023

Overview of the Issue

--grpc_max_message_size int                                        Maximum allowed RPC message size. Larger messages will be rejected by gRPC with the error 'exceeding the max size'. (default 16777216)

that's what I see in the output of the vttablet flags.

Okay, looks reasonable.
Part of my cluster definition:

              - cell: eucentral1b
                type: replica
                replicas: 1
                vttablet:
                  extraFlags:
                    grpc_max_message_size: 134217728
                  resources:
                    requests:
                      cpu: 300m
                      memory: 512Mi
                    limits:
                      memory: 512Mi
                mysqld:
                  configOverrides: |
                    max_allowed_packet = 134217728
                  resources:
                    requests:
                      cpu: 1600m
                      memory: 1Gi
                dataVolumeClaimTemplate:
                  accessModes: ["ReadWriteOnce"]
                  storageClassName: "io2-10k"
                  resources:
                    requests:
                      storage: 50Gi

when I try to apply the cluster definition, I am getting the following error:

knv apply -f cluster_k8s-mysql.yml 
The VitessCluster "test" is invalid: spec.keyspaces.partitionings.custom.shards.tabletPools.vttablet.extraFlags.grpc_max_message_size: Invalid value: "integer": spec.keyspaces.partitionings.custom.shards.tabletPools.vttablet.extraFlags.grpc_max_message_size in body must be of type string: "integer"

Reproduction Steps

Add to your cluster def under the vttablet the following:

                vttablet:
                  extraFlags:
                    grpc_max_message_size: 134217728

try to apply

knv apply -f cluster_k8s-mysql.yml 
The VitessCluster "test" is invalid: spec.keyspaces.partitionings.custom.shards.tabletPools.vttablet.extraFlags.grpc_max_message_size: Invalid value: "integer": spec.keyspaces.partitionings.custom.shards.tabletPools.vttablet.extraFlags.grpc_max_message_size in body must be of type string: "integer"

Binary Version

16.0.0

Operating System and Environment details

EKS, 1.23

Log Fragments

No response

@Areso Areso added Needs Triage This issue needs to be correctly labelled and triaged Type: Bug labels Mar 23, 2023
@Areso
Copy link
Author

Areso commented Mar 23, 2023

The accepting value is string type:

                vttablet:
                  extraFlags:
                    grpc_max_message_size: "134217728"

(which means 128 MB)

@deepthi
Copy link
Member

deepthi commented Mar 24, 2023

This is a vitess-operator issue, not a core vitess issue. Can you please open it in https://github.com/planetscale/vitess-operator?

@Areso
Copy link
Author

Areso commented Mar 27, 2023

@Areso Areso closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants