Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: evalengine doesn't honor changed sql_mode #14618

Open
dbussink opened this issue Nov 27, 2023 · 0 comments
Open

Feature Request: evalengine doesn't honor changed sql_mode #14618

dbussink opened this issue Nov 27, 2023 · 0 comments
Assignees
@dbussink
Labels
Component: Evalengine changes to the evaluation engine Type: Feature

Comments

@dbussink
Copy link
Contributor

Feature Description

The bug fixed in #14610 shows that we have missing functionality in the evalengine. In case sql_mode is changed from the default configuration, the evalengine doesn't honor that configuration.

This applies to NO_ZERO_DATE, but also to things like STRICT_TRANS_TABLES and how it does typecasting internally. #14610 fixed the original mismatch in evalengine behavior and the default SQL mode, but this tracks a separate feature request for the evalengine to honor this.

Use Case(s)

Changing sql_mode to allow zero dates or run in non strict mode should change the evalengine behavior.
@dbussink dbussink added Type: Feature Needs Triage This issue needs to be correctly labelled and triaged labels Nov 27, 2023
@shlomi-noach shlomi-noach added Component: Evalengine changes to the evaluation engine and removed Needs Triage This issue needs to be correctly labelled and triaged labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbussink dbussink

Labels
Component: Evalengine changes to the evaluation engine Type: Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbussink @shlomi-noach