Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: vtorc to support --topo_read_concurrency limit #17073

Closed
timvaillancourt opened this issue Oct 25, 2024 · 1 comment · Fixed by #17071
Closed

Feature Request: vtorc to support --topo_read_concurrency limit #17073

timvaillancourt opened this issue Oct 25, 2024 · 1 comment · Fixed by #17071
Assignees
Labels
Component: VTorc Vitess Orchestrator integration Type: Performance

Comments

@timvaillancourt
Copy link
Contributor

Feature Description

This issue requests VTOrc supports and respects the --topo_read_concurrency flag that several other Vitess components support, but not VTOrc

Today (v21) VTOrc is creating a new, unbounded goroutine for each tablet it wants to fetch from the topo which leads to some inefficiencies and a large number of unbounded network connections to the topo

The fix for this is implemented in #17071

Use Case(s)

Regular VTOrc users

@timvaillancourt
Copy link
Contributor Author

There are topo calls not covered by #17071. This will be continued in the somewhat-duplicate issue #17275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTorc Vitess Orchestrator integration Type: Performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant