Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Expose underlying LocalAddr() for connections #17255

Closed
desdic opened this issue Nov 19, 2024 · 4 comments
Closed

Feature Request: Expose underlying LocalAddr() for connections #17255

desdic opened this issue Nov 19, 2024 · 4 comments
Labels
Needs Triage This issue needs to be correctly labelled and triaged

Comments

@desdic
Copy link

desdic commented Nov 19, 2024

Feature Description

when using multiple IP its sometimes nice to know which IP the client connected to

Use Case(s)

having multiple IP's for the server

@desdic desdic added the Needs Triage This issue needs to be correctly labelled and triaged label Nov 19, 2024
@desdic
Copy link
Author

desdic commented Nov 19, 2024

Added a PR #17256

@dbussink
Copy link
Contributor

What are you trying to solve here? How are you using Vitess?

@desdic
Copy link
Author

desdic commented Nov 19, 2024

I'm using vitess for authentication mysql/mariadb in a proxy I'm creating. I need the to IP to check which authentication system I need to resolve the user (and where to send the request). But the underlying connection is not exposed so by adding a simple function I can now get the IP that is connected to.

@desdic
Copy link
Author

desdic commented Nov 19, 2024

oh this is embarrassing that I actually missed that one. Thank you, I'll close my PR.

@desdic desdic closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage This issue needs to be correctly labelled and triaged
Projects
None yet
Development

No branches or pull requests

2 participants