Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Follow-up Work for v22.0 Code Freeze #17734

Open
mattlord opened this issue Feb 10, 2025 · 0 comments · May be fixed by #17894
Open

Deprecation Follow-up Work for v22.0 Code Freeze #17734

mattlord opened this issue Feb 10, 2025 · 0 comments · May be fixed by #17894
Assignees
Labels
Component: General Changes throughout the code base Release Blocker: release-22.0 This item blocks the release of v22 Type: Internal Cleanup
Milestone

Comments

@mattlord
Copy link
Contributor

mattlord commented Feb 10, 2025

Here's a list of deprecation related follow-up work that has not yet happened and which should be done in v22 before the code freeze:

  1. Add session flag for stream execute grpc api #14046 (--grpc-send-session-in-streaming)

    • Backport to v17 (disabled - default) - Done
    • Mark for deprecation in v18 (enabled - default) - Not done
    • Removed in v19 - Not done
    • On main/v22: go/vt/vtgate/grpcvtgateservice/server.go: fs.BoolVar(&sendSessionInStreaming, "grpc-send-session-in-streaming", false, "If set, will send the session as last packet in streaming api to support transactions in streaming")
  2. Deprecate old reparent metrics and replace with new ones #16031

  3. Deprecate old metrics in VTOrc and replace with new ones #15994

  4. deprecate queryserver-enable-settings-pool flag #16280

    • Remove the deprecated flag
  5. Deprecate vttablet metrics QueryCacheXX and rename to QueryPlanCacheXX #16289

    • Remove the deprecated metrics
  6. Move concurrent connection dial limit out of healthcheck. #16378

@mattlord mattlord added this to the v22.0.0 milestone Feb 10, 2025
@deepthi deepthi added Release Blocker: release-22.0 This item blocks the release of v22 and removed Type: Release labels Feb 10, 2025
@frouioui frouioui linked a pull request Mar 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Release Blocker: release-22.0 This item blocks the release of v22 Type: Internal Cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants