You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue proposes that the GitHub Actions workflows and Docker-based builds support the use of Golang packages in private Git(Hub) repos, in order to allow users with custom durability policies in private repos to smoothly build Vitess
Today Slack applies these patches to our fork to achieve this, but having this supported upstream would probably benefit other users with a fork and a custom durability policy:
Where ${{secrets.GH_ACCESS_TOKEN}} is a GitHub Secret a user sets in their fork. It's possible GOPRIVATE needs to be set too
On the Docker-build side, adding the ability to pass the token into the build will be required, via: --build-arg GH_ACCESS_TOKEN=${GH_ACCESS_TOKEN}. Finally, Dockerfiles will need to be updated to run a similar git config command as the CI
Use Case(s)
Users that have a custom Durability Policy in a private git-repo, which admittedly is probably a small group, but this may change if the interface concept is adopted more widely - I have an RFC queued up that would add a similar interface for sending "events", for example
The text was updated successfully, but these errors were encountered:
Feature Description
This issue proposes that the GitHub Actions workflows and Docker-based builds support the use of Golang packages in private Git(Hub) repos, in order to allow users with custom durability policies in private repos to smoothly build Vitess
Today Slack applies these patches to our fork to achieve this, but having this supported upstream would probably benefit other users with a fork and a custom durability policy:
slack-vitess-r15.0.5
: addslack_cross_cell
custom durability policy slackhq/vitess#266slack-15.0
: fix private repo git config in docker build slackhq/vitess#367The meat of this change would be including the following in
.github/workflow
files (made bytest/templates
files):Where
${{secrets.GH_ACCESS_TOKEN}}
is a GitHub Secret a user sets in their fork. It's possibleGOPRIVATE
needs to be set tooOn the Docker-build side, adding the ability to pass the token into the build will be required, via:
--build-arg GH_ACCESS_TOKEN=${GH_ACCESS_TOKEN}
. Finally,Dockerfile
s will need to be updated to run a similargit config
command as the CIUse Case(s)
Users that have a custom Durability Policy in a private git-repo, which admittedly is probably a small group, but this may change if the interface concept is adopted more widely - I have an RFC queued up that would add a similar interface for sending "events", for example
The text was updated successfully, but these errors were encountered: