Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support private go packages #16018

Open
timvaillancourt opened this issue May 27, 2024 · 0 comments · May be fixed by #17806
Open

Feature Request: support private go packages #16018

timvaillancourt opened this issue May 27, 2024 · 0 comments · May be fixed by #17806

Comments

@timvaillancourt
Copy link
Contributor

timvaillancourt commented May 27, 2024

Feature Description

This issue proposes that the GitHub Actions workflows and Docker-based builds support the use of Golang packages in private Git(Hub) repos, in order to allow users with custom durability policies in private repos to smoothly build Vitess

Today Slack applies these patches to our fork to achieve this, but having this supported upstream would probably benefit other users with a fork and a custom durability policy:

  1. slack-vitess-r15.0.5: add slack_cross_cell custom durability policy  slackhq/vitess#266
  2. slack-15.0: fix private repo git config in docker build slackhq/vitess#367

The meat of this change would be including the following in .github/workflow files (made by test/templates files):

    - name: Setup github.com/slackhq/vitess-additions access token
      run: git config --global url.https://${{secrets.GH_ACCESS_TOKEN}}@github.com/.insteadOf https://github.com/
      if: ${{secrets.GH_ACCESS_TOKEN}} != ""

Where ${{secrets.GH_ACCESS_TOKEN}} is a GitHub Secret a user sets in their fork. It's possible GOPRIVATE needs to be set too

On the Docker-build side, adding the ability to pass the token into the build will be required, via: --build-arg GH_ACCESS_TOKEN=${GH_ACCESS_TOKEN}. Finally, Dockerfiles will need to be updated to run a similar git config command as the CI

Use Case(s)

Users that have a custom Durability Policy in a private git-repo, which admittedly is probably a small group, but this may change if the interface concept is adopted more widely - I have an RFC queued up that would add a similar interface for sending "events", for example

@timvaillancourt timvaillancourt added Type: Feature Needs Triage This issue needs to be correctly labelled and triaged labels May 27, 2024
@timvaillancourt timvaillancourt self-assigned this May 27, 2024
@deepthi deepthi removed the Needs Triage This issue needs to be correctly labelled and triaged label Jul 2, 2024
@timvaillancourt timvaillancourt linked a pull request Feb 17, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants