From 08a5fc6bc6e18a6459c58fccb02a31db6a821c58 Mon Sep 17 00:00:00 2001 From: Manan Gupta Date: Wed, 13 Mar 2024 12:22:17 +0530 Subject: [PATCH] feat: alternate fix for concatenate panic Signed-off-by: Manan Gupta --- go/test/endtoend/vtgate/queries/union/union_test.go | 8 +++++--- go/vt/vtgate/engine/concatenate.go | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/go/test/endtoend/vtgate/queries/union/union_test.go b/go/test/endtoend/vtgate/queries/union/union_test.go index d91ea3c4073..582b22788f7 100644 --- a/go/test/endtoend/vtgate/queries/union/union_test.go +++ b/go/test/endtoend/vtgate/queries/union/union_test.go @@ -111,9 +111,11 @@ func TestUnionAll(t *testing.T) { mcmp.AssertMatchesNoOrder("select tbl2.id1 FROM ((select id1 from t1 order by id1 limit 5) union all (select id1 from t1 order by id1 desc limit 5)) as tbl1 INNER JOIN t1 as tbl2 ON tbl1.id1 = tbl2.id1", "[[INT64(1)] [INT64(2)] [INT64(2)] [INT64(1)]]") - // union all between two select unique in tables - mcmp.AssertMatchesNoOrder("select id1 from t1 where id1 in (1, 2, 3, 4, 5, 6, 7, 8) union all select id1 from t1 where id1 in (1, 2, 3, 4, 5, 6, 7, 8)", - "[[INT64(1)] [INT64(2)] [INT64(1)] [INT64(2)]]") + for i := 0; i < 5000; i++ { + // union all between two select unique in tables + mcmp.AssertMatchesNoOrder("select id1 from t1 where id1 in (1, 2, 3, 4, 5, 6, 7, 8) union all select id1 from t1 where id1 in (1, 2, 3, 4, 5, 6, 7, 8)", + "[[INT64(1)] [INT64(2)] [INT64(1)] [INT64(2)]]") + } // 4 tables union all mcmp.AssertMatchesNoOrder("select id1, id2 from t1 where id1 = 1 union all select id3,id4 from t2 where id3 = 3 union all select id1, id2 from t1 where id1 = 2 union all select id3,id4 from t2 where id3 = 4", diff --git a/go/vt/vtgate/engine/concatenate.go b/go/vt/vtgate/engine/concatenate.go index 352b190fb1d..1e1f0f7d470 100644 --- a/go/vt/vtgate/engine/concatenate.go +++ b/go/vt/vtgate/engine/concatenate.go @@ -309,7 +309,7 @@ func (c *Concatenate) parallelStreamExec(inCtx context.Context, vcursor VCursor, } } // Wait for fields from all sources. - for slices.Contains(rest, nil) { + for len(fieldTypes) == 0 { condFields.Wait() } muFields.Unlock()