Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to Go SQL driver #15569

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add types to Go SQL driver #15569

merged 1 commit into from
Mar 26, 2024

Conversation

dbussink
Copy link
Contributor

This adds two interfaces, one for the type names and one for nullable to the Go SQL driver for Vitess. This is missing and means this type information can't be easily retrieved from result sets.

Related Issue(s)

Fixes #15568

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 26, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 26, 2024
shlomi-noach
shlomi-noach approved these changes Mar 26, 2024
View reviewed changes
go/vt/vitessdriver/rows.go Show resolved Hide resolved
@dbussink
Add types to Go SQL driver
8fd36b6 
This adds two interfaces, one for the type names and one for nullable to
the Go SQL driver for Vitess. This is missing and means this type
information can't be easily retrieved from result sets.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/add-type-names-driver branch from b01e5d5 to 8fd36b6 Compare March 26, 2024 08:48
@dbussink dbussink added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Driver and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 26, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 47.22222% with 38 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@90c0057). Click here to learn what that means.

Files Patch % Lines
go/vt/vitessdriver/rows.go 47.22% 38 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15569   +/-   ##
=======================================
  Coverage        ?   65.75%           
=======================================
  Files           ?     1561           
  Lines           ?   194827           
  Branches        ?        0           
=======================================
  Hits            ?   128118           
  Misses          ?    66709           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink merged commit e9c8d52 into vitessio:main Mar 26, 2024
108 checks passed
@dbussink dbussink deleted the dbussink/add-type-names-driver branch March 26, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Driver Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Vitess Go SQL driver does not implement ColumnTypeDatabaseTypeName
3 participants
@dbussink @shlomi-noach @GuptaManan100