Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revealjs: wrong BASE URL #183

Open
linuxmail opened this issue Apr 4, 2019 · 3 comments · May be fixed by #184
Open

revealjs: wrong BASE URL #183

linuxmail opened this issue Apr 4, 2019 · 3 comments · May be fixed by #184

Comments

@linuxmail
Copy link

hi,

It seems, that the Revealjs does not use the configured baseURL. I have /doc/ and revealjs does not work, because https://foo.exmaple.com/revealjs does not exist, but https://foo.exmaple.com/doc/revealjs/ does.

Is there a way to fix it ?

cu denny

ps. Thanks for the great theme :-)
@linuxmail
Copy link
Author

hi,

I've found these lines:

hugo-theme-docdock/layouts/shortcodes/revealjs.html

Lines 20 to 21 in 1d12f57

<script async src="{{"/revealjs/lib/js/head.min.js"|relURL}}"></script>
<script async src="{{"/revealjs/js/reveal.js"|relURL}}"></script>

hugo-theme-docdock/layouts/slide/single.html

Lines 17 to 18 in 1d12f57

<script src="{{"/revealjs/lib/js/head.min.js"|relURL}}"></script>
<script src="{{"/revealjs/js/reveal.js"|relURL}}"></script>

which has a "/" at the beginning

cu denny

@linuxmail linuxmail linked a pull request Apr 4, 2019 that will close this issue
Open
@id027102
Copy link

Here also working with subdomain , and need to set canonifyurls to true to get working with subdomain , but then revealjs is not more working , and with canonifyurls set to false links does not uses subdomains (images not displaying) but revealjs is working .
The starting "/" is not removed ,but removing it does NOT help.
Hope somebody can help.

@id027102
Copy link

There must be a difference in working with canonifyurls set to true or false .
The generated html files are exactly the sames with canonifyurls set to TRUE or FALSE .
But with set to TRUE : SLIDE DOES NOT WORK.
And set to FALSE : SLIDE IS WORKING.
If you save the page souce from your browser : it NEVER works again (display the same as for canonifyurls set to true).
It seems of nobody follows this site , it is here for the fun only.
So I have to look for another (working) theme .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the starting "/" to get Revealjs working for non baseurl "/" linuxmail/hugo-theme-docdock
2 participants
@linuxmail @id027102