Skip to content

chore/bump dependencies #16

chore/bump dependencies

chore/bump dependencies #16

Triggered via pull request November 22, 2024 19:23
Status Success
Total duration 3m 20s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
variant name ends with the enum's name: src/main.rs#L81
warning: variant name ends with the enum's name --> src/app.rs:81:5 | 81 | EmpptyMessage, | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names = note: `#[warn(clippy::enum_variant_names)]` on by default
large size difference between variants: src/main.rs#L118
warning: large size difference between variants --> src/app.rs:118:1 | 118 | / pub enum DialogPage { 119 | | RemoveAccount(Account), | | ---------------------- the second-largest variant contains at least 104 bytes 120 | | RemoveBookmark(Account, Bookmark), | | --------------------------------- the largest variant contains at least 448 bytes 121 | | } | |_^ the entire enum is at least 448 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 120 | RemoveBookmark(Account, Box<Bookmark>), | ~~~~~~~~~~~~~
useless conversion to the same type: `cosmic::iced_core::Element<'_, app::Message, cosmic::Theme, cosmic::iced_renderer::fallback::Renderer<cosmic::iced_wgpu::Renderer, iced_tiny_skia::Renderer>>`: src/main.rs#L279
warning: useless conversion to the same type: `cosmic::iced_core::Element<'_, app::Message, cosmic::Theme, cosmic::iced_renderer::fallback::Renderer<cosmic::iced_wgpu::Renderer, iced_tiny_skia::Renderer>>` --> src/app.rs:279:13 | 279 | (widget::toaster(&self.toasts, widget::horizontal_space()).into()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `widget::toaster(&self.toasts, widget::horizontal_space())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
this boolean expression can be simplified: src/main.rs#L839
warning: this boolean expression can be simplified --> src/app.rs:839:20 | 839 | if !self.dialog_pages.pop_front().is_some() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dialog_pages.pop_front().is_none()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool = note: `#[warn(clippy::nonminimal_bool)]` on by default
this boolean expression can be simplified: src/main.rs#L845
warning: this boolean expression can be simplified --> src/app.rs:845:20 | 845 | if !self.dialog_pages.pop_front().is_some() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dialog_pages.pop_front().is_none()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
this let-binding has unit value: src/main.rs#L372
warning: this let-binding has unit value --> src/app.rs:372:17 | 372 | _ = self.nav.activate(account_page_entity.unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.nav.activate(account_page_entity.unwrap());` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default
redundant closure: src/main.rs#L885
warning: redundant closure --> src/app.rs:885:21 | 885 | |msg| cosmic::app::Message::App(msg), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `cosmic::app::Message::App` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
unneeded `return` statement: src/main.rs#L77
warning: unneeded `return` statement --> src/db/mod.rs:77:9 | 77 | return data; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 77 - return data; 77 + data |
the borrowed expression implements the required traits: src/main.rs#L90
warning: the borrowed expression implements the required traits --> src/db/mod.rs:90:19 | 90 | .bind(&account.id) | ^^^^^^^^^^^ help: change this to: `account.id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
the borrowed expression implements the required traits: src/main.rs#L94
warning: the borrowed expression implements the required traits --> src/db/mod.rs:94:19 | 94 | .bind(&account.tls) | ^^^^^^^^^^^^ help: change this to: `account.tls` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args