Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and change the reduction operation #7

Open
wants to merge 4 commits into
base: ipu_develop
Choose a base branch
from

Conversation

WardLT
Copy link

@WardLT WardLT commented Mar 1, 2023

The original implementation of our network changes its value of predictions depending on the amount of padding, which is unphysical.

This change moves to using a custom layer that ensures that we do not include the padding when computing the property of a molecule.

@WardLT
Copy link
Author

WardLT commented Mar 1, 2023

While at it, I moved the updates from NFP to a separate repo so that I can use them more easily between projects and cleaned a few other things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant