From 9b45a449f3a19cb4a234ebdb16076ce5dd85dc6a Mon Sep 17 00:00:00 2001 From: Harry Mellor <19981378+hmellor@users.noreply.github.com> Date: Tue, 28 Jan 2025 20:54:23 +0000 Subject: [PATCH 1/5] Add label if pre-commit passes Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --- .github/workflows/add_label_precommit.yml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/workflows/add_label_precommit.yml diff --git a/.github/workflows/add_label_precommit.yml b/.github/workflows/add_label_precommit.yml new file mode 100644 index 0000000000000..75ffd630ca1c7 --- /dev/null +++ b/.github/workflows/add_label_precommit.yml @@ -0,0 +1,22 @@ +name: Add label on pre-commit success +on: + workflow_run: + workflows: ["pre-commit"] + types: [completed] +jobs: + add-label-on-pre-commit-success: + runs-on: ubuntu-latest + if: ${{ github.event.workflow_run.conclusion == 'success' }} + steps: + - name: Add label + uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 + with: + script: | + github.rest.issues.addLabels({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + labels: ['pre-commit passed'] + }) + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file From 4a8c0aa8c370edb22298148e599373d46fe8e6fc Mon Sep 17 00:00:00 2001 From: Harry Mellor <19981378+hmellor@users.noreply.github.com> Date: Tue, 28 Jan 2025 21:06:40 +0000 Subject: [PATCH 2/5] Remove quotes from name Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --- .github/workflows/add_label_precommit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/add_label_precommit.yml b/.github/workflows/add_label_precommit.yml index 75ffd630ca1c7..2c6d54a90a68e 100644 --- a/.github/workflows/add_label_precommit.yml +++ b/.github/workflows/add_label_precommit.yml @@ -1,7 +1,7 @@ name: Add label on pre-commit success on: workflow_run: - workflows: ["pre-commit"] + workflows: [pre-commit] types: [completed] jobs: add-label-on-pre-commit-success: From a581a75df587f9c1c920833f734c22c7867cb442 Mon Sep 17 00:00:00 2001 From: Harry Mellor <19981378+hmellor@users.noreply.github.com> Date: Tue, 28 Jan 2025 21:34:03 +0000 Subject: [PATCH 3/5] Also trigger on requested and remove label if that happened Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --- .github/workflows/add_label_precommit.yml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/workflows/add_label_precommit.yml b/.github/workflows/add_label_precommit.yml index 2c6d54a90a68e..65982044e0c1a 100644 --- a/.github/workflows/add_label_precommit.yml +++ b/.github/workflows/add_label_precommit.yml @@ -2,7 +2,7 @@ name: Add label on pre-commit success on: workflow_run: workflows: [pre-commit] - types: [completed] + types: [requested, completed] jobs: add-label-on-pre-commit-success: runs-on: ubuntu-latest @@ -18,5 +18,21 @@ jobs: issue_number: context.issue.number, labels: ['pre-commit passed'] }) + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + remove-label-on-pre-commit-failure: + runs-on: ubuntu-latest + if: ${{ github.event.workflow_run.conclusion != 'success' }} + steps: + - name: Remove label + uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 + with: + script: | + github.rest.issues.removeLabels({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + labels: ['pre-commit passed'] + }) env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file From b5b6a20419a636ccaafafc75b454cad05302d94c Mon Sep 17 00:00:00 2001 From: Harry Mellor <19981378+hmellor@users.noreply.github.com> Date: Wed, 29 Jan 2025 22:35:50 +0000 Subject: [PATCH 4/5] Respond to comments Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --- .github/workflows/add_label_precommit.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/add_label_precommit.yml b/.github/workflows/add_label_precommit.yml index 65982044e0c1a..289d095be31f3 100644 --- a/.github/workflows/add_label_precommit.yml +++ b/.github/workflows/add_label_precommit.yml @@ -16,7 +16,7 @@ jobs: owner: context.repo.owner, repo: context.repo.repo, issue_number: context.issue.number, - labels: ['pre-commit passed'] + labels: ['pre-commit-passed'] }) env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -35,4 +35,4 @@ jobs: labels: ['pre-commit passed'] }) env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From e0e8801309555eef133ba7d67fbacc2578a334b6 Mon Sep 17 00:00:00 2001 From: Harry Mellor <19981378+hmellor@users.noreply.github.com> Date: Thu, 30 Jan 2025 17:11:01 +0000 Subject: [PATCH 5/5] Rename label removal job Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --- .github/workflows/add_label_precommit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/add_label_precommit.yml b/.github/workflows/add_label_precommit.yml index 289d095be31f3..a88b44f03a560 100644 --- a/.github/workflows/add_label_precommit.yml +++ b/.github/workflows/add_label_precommit.yml @@ -20,7 +20,7 @@ jobs: }) env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - remove-label-on-pre-commit-failure: + remove-label-on-pre-commit-not-success: runs-on: ubuntu-latest if: ${{ github.event.workflow_run.conclusion != 'success' }} steps: