From c4aff209c771065f28651b48b77b4275046431bf Mon Sep 17 00:00:00 2001 From: Emily Johnson <51918476+emmjohnson@users.noreply.github.com> Date: Thu, 21 Oct 2021 13:31:19 -0500 Subject: [PATCH] Fix gh release command (#259) --- CONTRIBUTING.md | 2 +- hack/publish-github-release.sh | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bf6523794..dad4730db 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -202,7 +202,7 @@ Although `2` is automated, it's still possible to do the procedure manually. 1. Check the previous release - https://github.com/vmware-tanzu/cartographer/releases 2. Create a tag for the new release ```bash -git tag v0.0.x # or v0.0.x-rcn +git tag v0.0.x # or v0.0.x-rc.n git push origin ``` 3. Ensure workflow has kicked off - https://github.com/vmware-tanzu/cartographer/actions diff --git a/hack/publish-github-release.sh b/hack/publish-github-release.sh index 7cfedca96..e474a7e0c 100755 --- a/hack/publish-github-release.sh +++ b/hack/publish-github-release.sh @@ -33,13 +33,14 @@ main() { submit_release_to_github() { local version=v$1 - local release_notes_basename - release_notes_basename="$(basename $RELEASE_NOTES_FILE)" - gh release create $version \ --draft \ --notes-file $RELEASE_NOTES_FILE \ - "$(find $ASSETS_DIR -type f ! -name $release_notes_basename)" + ./release/package/package.yaml \ + ./release/package/package-install.yaml \ + ./release/package/package-metadata.yaml \ + ./release/bundle.tar \ + ./release/cartographer.yaml } git_current_version() {