Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider passing non-user configurable properties into vAppConfig #181

Open
zyiyi11 opened this issue Jul 18, 2023 · 0 comments · May be fixed by #217
Open

Consider passing non-user configurable properties into vAppConfig #181

zyiyi11 opened this issue Jul 18, 2023 · 0 comments · May be fixed by #217

Comments

@zyiyi11
Copy link
Contributor

zyiyi11 commented Jul 18, 2023

We have a user trying to use Nested ESXi OVA, which includes one hidden property (used for debugging purposes), but it had no value set after deployed. The only way to resolve this right now was to import the OVA into vSphere, change the hidden property to configurable AND then specify that in vAppConfig spec and VM Service was able to power it on.

For basic OVF/OVA, this is not an issue but for more complex ones that leverage hidden properties. other VMware appliances like VCSA also uses hidden properties for various reasons

Please describe the solution you would like.
Right now, any non user configurable properties are ignored. We can consider passing these into vAppConfig.
ref:

for _, vmProp := range vmProps {
if vmProp.UserConfigurable == nil || !*vmProp.UserConfigurable {
continue
}

Is there anything else you would like to add?

Please tell us about your environment.

Value How to Obtain
Supervisor version rpm -qa VMware-wcp on the vCenter appliance
Supervisor node image version rpm -qa VMware-wcpovf on the vCenter appliance
Kubernetes version kubectl version
VM Operator version
kubectl -n vmware-system-vmop get pods \
  -ojsonpath='{range .items[*].spec.containers[*]}{.image}{"\n"}{end}' | \
  sort -u | \
  grep vmop | \
  awk -F'/' '{print $3}' | \
  awk -F: '{print $2}'
aruneshpa added a commit to aruneshpa/vm-operator that referenced this issue Sep 7, 2023
Currently, VM operator ignores any vApp properties that are not user
configurable when patching with values specified in the bootstrap
resources (VM metadata ConfigMap/Secret). There are some valid
use-cases where users might want to patch hidden properties defined in
an image. This change fixes this behavior.

Fixes vmware-tanzu#181.
aruneshpa added a commit to aruneshpa/vm-operator that referenced this issue Sep 7, 2023
Currently, VM operator ignores any vApp properties that are not user
configurable when patching with values specified in the bootstrap
resources (VM metadata ConfigMap/Secret). There are some valid
use-cases where users might want to patch hidden properties defined in
an image. This change fixes this behavior.

Fixes vmware-tanzu#181.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant