Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics and logs to emit total number of OVF cached items #332

Open
dilyar85 opened this issue Jan 4, 2024 · 0 comments
Open

Add metrics and logs to emit total number of OVF cached items #332

dilyar85 opened this issue Jan 4, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@dilyar85
Copy link
Member

dilyar85 commented Jan 4, 2024

Please describe the solution you would like.
Currently, we lack information about the size of the OVF cache used during VM image reconciliation. It would be beneficial to add logs that provide this information when updating the cache here:

putResult := vs.ovfCache.Put(itemID, cacheItem)
logger.Info("Cache item put", "itemID", itemID, "putResult", putResult)

Is there anything else you would like to add?
This may also require a function added in the Cache to expose the size of its items.

Additionally, we should emit prometheus metrics for total number of cached items which can help root cause issues that result in the VM operator pod running out of memory.

Please tell us about your environment.
N/A

@dilyar85 dilyar85 added the good first issue Good for newcomers label Jan 4, 2024
@aruneshpa aruneshpa changed the title Add logs to emit total number of OVF cached items Add metrics and logs to emit total number of OVF cached items Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant