Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netoperator.vmware.com_networkinterfaces.yaml in config/crd/external-crds is missing status subresource #479

Open
fabriziopandini opened this issue Apr 22, 2024 · 2 comments

Comments

@fabriziopandini
Copy link
Member

What steps did you take and what happened?

I was using the netoperator.vmware.com_networkinterfaces.yaml CRD while testing CAPV in supervisor mode / Implementing a fake net-operator, and wasn't able to patch status.

What did you expect to happen?

Being able to set status on networkinterfaces

@akutz
Copy link
Collaborator

akutz commented Apr 22, 2024

Hmm. We only include these resources for testing. They are not intended to be authoritative. We do not pull them into the WCP deployment YAML for example. The authoritative source for these are https://github.com/vmware-tanzu/net-operator-api -- the CRDs are just not built there. I do not know why the decision was made to include the netop CRDs here instead of building them in their own repo. @bryanv / @hkumar1402, do you know why?

@fabriziopandini
Copy link
Member Author

Even if non authoritative (which is clear to me because those are clearly defined external crd), having a copy of those CRDs in sync with what vm-operator expect is really, really valuable for a couple of reasons; the most important probably is the following:

As noted above https://github.com/vmware-tanzu/net-operator-api is not publishing CRDs, but this is only a part of the problem, because a few other CRDs definitions are required as well.

Consering this, reverse engineering what version of those CRDs the vm-operator expects at any time will be a difficult and error prone exercise for a person not involved in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants