Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Update links to the explorer #404

Open
elboletaire opened this issue Jul 31, 2024 · 2 comments
Open

feature: Update links to the explorer #404

elboletaire opened this issue Jul 31, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@elboletaire
Copy link
Member

elboletaire commented Jul 31, 2024

Describe the feature

With the complete revamp of the explorer, all routes receiving params have been changed. We should update any explorer links in the explorer and its docs to properly point to the new ones.

Note

Even though the SDK code itself may not have links pointing there, we have lots of examples and documentation where we might be pointing to the old urls.

See vocdoni/ui-scaffold#740 for a full list of the routes that have potentially changed.

Note the explorer will have support for old routes, so this won't be required immediately, but it would be good to do it as soon as the LTS explorer has been finally deployed (see vocdoni/explorer#81 for a follow-up on this).

@elboletaire elboletaire added the enhancement New feature or request label Jul 31, 2024
@marcvelmer
Copy link
Collaborator

URLs are the same, there are no routes in the SDK

@elboletaire
Copy link
Member Author

elboletaire commented Sep 4, 2024

This was to review all readmes and examples (I should have been more clear, sorry for that), I see some links in the examples...

https://github.com/vocdoni/vocdoni-sdk/blob/main/examples/tutorial/src/vote.ts#L13

@elboletaire elboletaire reopened this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants