Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TypedModel and properly onboard pydantic v2 #653

Closed
ajar98 opened this issue Jul 19, 2024 · 4 comments
Closed

Deprecate TypedModel and properly onboard pydantic v2 #653

ajar98 opened this issue Jul 19, 2024 · 4 comments
Assignees
@ajar98
Labels
stale

Comments

@ajar98
Copy link
Contributor

ajar98 commented Jul 19, 2024

We use TypedModel to allow us to deserialize Configs to typed objects with discriminated unions when they are coming out of the ConfigManager, for example. It isn't great for a few reasons:

  • it's very brittle, and doesn't work for 3-depth nested objects
  • it's not compatible with pydantic v2
@ajar98 ajar98 self-assigned this Jul 19, 2024
@ajar98 ajar98 converted this from a draft issue Jul 19, 2024
@ajar98 ajar98 linked a pull request Jul 19, 2024 that will close this issue
deprecate TypedModel and properly onboard pydantic v2 #630
Closed
@ajar98 ajar98 moved this to In Progress in Vocode Core 0.2.0 Jul 19, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 18, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically closed due to inactivity. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Vocode Core 0.2.0 Sep 25, 2024
@ajar98 ajar98 reopened this Oct 2, 2024
@github-actions github-actions bot removed the stale label Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

This issue has been automatically closed due to inactivity. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajar98 ajar98

Labels
stale
Projects
Vocode Core 0.2.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecate TypedModel and properly onboard pydantic v2 vocodedev/vocode-core
1 participant
@ajar98