Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dos_header.reconstruct() calls need to catch ValueError #1637

Open
atcuno opened this issue Feb 26, 2025 · 0 comments
Open

dos_header.reconstruct() calls need to catch ValueError #1637

atcuno opened this issue Feb 26, 2025 · 0 comments
Assignees

Comments

@atcuno
Copy link
Contributor

atcuno commented Feb 26, 2025

This function throws ValueErrors in many places, but all the calling plugins all over the code base (likely copy/paste from a long time ago), only catch for invalidaddress exception. Once the GUI code and API overhaul PR is merged, then we need to hunt down these calls and catch the right exception.

@atcuno atcuno self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant