Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reminder: Remove jsonschema from environments #152

Closed
Tracked by #296
dominiquesydow opened this issue Oct 4, 2021 · 0 comments · Fixed by #297 or #296
Closed
Tracked by #296

Reminder: Remove jsonschema from environments #152

dominiquesydow opened this issue Oct 4, 2021 · 0 comments · Fixed by #297 or #296
Assignees
@dominiquesydow
Labels
dependencies Update/fix dependencies

Comments

@dominiquesydow
Copy link
Collaborator

dominiquesydow commented Oct 4, 2021 •
edited
Loading

Remove jsonschema from environments once this is resolved: Yelp/bravado#478

More details below.

Description

T011+T012+T014 use a Swagger API via bravado.

We get the following error in our CI probably since the 4.0.0 release of jsonschema used by swagger_spec_validator used by bravado:

ModuleNotFoundError: No module named 'jsonschema.compat'

CI error:
https://github.com/volkamerlab/teachopencadd/runs/3787319091#step:8:1267

Solution

Short-term

Pin jsonschema to <4.0.0

Long-term

Wait for swagger_spec_validator's fix.
@dominiquesydow dominiquesydow self-assigned this Oct 4, 2021
This was referenced Oct 4, 2021
Merged
Closed
@dominiquesydow dominiquesydow changed the title Remove jsonschema from environments Reminder: Remove jsonschema from environments Oct 14, 2021
@dominiquesydow dominiquesydow added the dependencies Update/fix dependencies label Aug 1, 2022
@dominiquesydow dominiquesydow mentioned this issue Dec 27, 2022
Merged
4 tasks
This was linked to pull requests Dec 27, 2022
T011/12: Remove pinned jsonschema from env #297
Merged
Base branch for CI/env fixes #296
Merged
@dominiquesydow dominiquesydow mentioned this issue Dec 30, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominiquesydow dominiquesydow

Labels
dependencies Update/fix dependencies
Projects
None yet
Milestone
No milestone
1 participant
@dominiquesydow