Special characters at cifs mount password is not handled well

[baratiistok3]

for example use a share with password: aF5T,g1f&QqqTx2E9w4f+19sm^f+g9 is not possible

In the logs I can see the following:
info: Share nas successfully unmounted volumio : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/bin/mount -t cifs -o username=volumio,password=aF5T,g1f&QqqTx2E9w4f+19sm^f+g9,ro,dir_mode=0777,file_mode=0666,iocharset=utf8,noauto,soft //*************/volumio /mnt/NAS/nas pam_unix(sudo:session): session opened for user root by (uid=0) pam_unix(sudo:session): session closed for user root info: An error occurred mounting the new share. Rolling back configuration CIFS: Attempting to mount //*************/volumio CIFS: Unknown mount option "g1f&QqqTx2E9w4f+19sm^f+g9"

[volumio]

We shall probably encapsulate password with "

@ashthespy what do you think?

[ashthespy]

Isn't this already done by properQuote

volumio3-backend/app/plugins/system_controller/networkfs/index.js

Lines 1304 to 1305 in d1eed29

	ControllerNetworkfs.prototype.properQuote = function (str) {
	// returns str as a single-quoted string, safe for exposure to a shell.

Perhaps the later call to mountutils.mount is playing with the quotes?

I really can't make out, the networkfs stuff is quite messy and could do with some love! 😬