Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get version from pyproject.toml #39

Open
Simon-1-1 opened this issue Jun 3, 2022 · 0 comments
Open

Get version from pyproject.toml #39

Simon-1-1 opened this issue Jun 3, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Simon-1-1
Copy link
Contributor

Simon-1-1 commented Jun 3, 2022 •
edited by plaos
Loading

Currently we're getting the version from more than one place which is error prone. When setting the __version__ variable internally, we should read the pyproject file with some toml parser (I think there is one in the dependencies) and get it from there, rather than hardcoding it again.
@plaos plaos added the enhancement New feature or request label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Simon-1-1 @plaos