Merge pull request #307 from vordgi/rd-306

rd-306 fix scrollIntoViewIfNeeded in firefox
vordgi · Oct 14, 2024 · 22ad9cb · 22ad9cb
2 parents 0a41886 + 8e217b3
commit 22ad9cb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/robindoc/package.json b/packages/robindoc/package.json
@@ -1,6 +1,6 @@
 {
   "name": "robindoc",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "description": "",
   "main": "./lib/index.js",
   "scripts": {

diff --git a/packages/robindoc/src/assets/base.scss b/packages/robindoc/src/assets/base.scss
@@ -17,6 +17,7 @@
 
 body {
   --header-height: 60px;
+  position: relative;
   padding: 0;
   margin: 0;
   accent-color: var(--primary600, #ea580c);

diff --git a/packages/robindoc/src/components/elements/sidebar/sidebar-link/index.tsx b/packages/robindoc/src/components/elements/sidebar/sidebar-link/index.tsx
@@ -27,7 +27,7 @@ export const SidebarLink: React.FC<SidebarLinkProps> = ({ link, branch, pathname
                 if (isTarget) {
                     scrollTimeoutRef.current = null;
                     // eslint-disable-next-line @typescript-eslint/no-explicit-any
-                    (node as any)?.parentElement?.scrollIntoViewIfNeeded();
+                    (node as any)?.parentElement?.scrollIntoViewIfNeeded?.();
                 }
             }}
         >