Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Screen #18

Closed
Vanethos opened this issue Aug 14, 2019 · 17 comments · Fixed by #77
Closed

About Screen #18

Vanethos opened this issue Aug 14, 2019 · 17 comments · Fixed by #77
Assignees
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these! Needs Maintainers Help The maintainer is needed for something

Comments

@Vanethos
Copy link
Contributor

Vanethos commented Aug 14, 2019

Description
About screen for VOST, including contacts, links to the contributors and tutorial screen

File Location

- presentation
|__ ui

Requirements

  • Include button to access Contributors screen
  • Include button to access Tutorial screen
  • All contacts should be clickable, either launch phone/email apps or use https://pub.dev/packages/url_launcher to open URLs

UI
imagem

NOTES

Assume the following test:

A VOST Portugal - Associação de Voluntários Em Situações de Emergência - é uma equipa de voluntários digitais que recolhe, valida, e informa as populações em casos de emergência. Esta aplicação, feita integralmente por voluntários e em código aberto, tem como objectivo colocar numa só aplicação mensagens oficiais no âmbito da autoprotecção, desastres naturais, e fenómenos meteorológicos adversos.

Assume that in the grid you will receive a List<Contacts> in which a Contact can have the following structure:

String name;
String imageUrl;
String info;
ContactType type; // this is an enum with the values ["PHONE", "URL", "EMAIL"]

Depending on the type, a click on this button can either open the phone app with the number ,open an url or send an email.

The buttons at the bottom of the screen should be clickable, so a function should be exposed to place there the callback

@Vanethos Vanethos added the Needs Maintainers Help The maintainer is needed for something label Aug 14, 2019
@Vanethos
Copy link
Contributor Author

@OldMetalmind Copy will be needed for this issue

@JorgeMiguelGomes
Copy link
Member

@Vanethos copy will be given ;) You can assign that task to me.

@Vanethos
Copy link
Contributor Author

@JorgeMiguelGomes done!

@OldMetalmind
Copy link
Member

OldMetalmind commented Aug 16, 2019

Let keep this issue open for developers to be assigned and create another issue only for the copy.

@OldMetalmind OldMetalmind added this to the v1.0.0 - Akita milestone Aug 16, 2019
@OldMetalmind OldMetalmind added the good first issue Good for newcomers label Aug 16, 2019
@Vanethos Vanethos added the hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these! label Sep 20, 2019
@Thesmader
Copy link
Contributor

Is it compulsory to use the BLoC architecture for this screen?

@Vanethos
Copy link
Contributor Author

Vanethos commented Oct 8, 2019

@Thesmader For this screen it is not since it's going to be composed of static data (for now).

If in the future we need to have dynamic data for the contacts, we will update it in a new issue

@Thesmader
Copy link
Contributor

I'm interested in taking this issue. Any specific guidelines to follow?

@Vanethos
Copy link
Contributor Author

Vanethos commented Oct 8, 2019

Sure!

Please read our Contributing guidelines: https://github.com/vostpt/mobile-app/blob/develop/CONTRIBUTING.md

  • When a Widget is for a Screen, add the suffix Page, AboutPage for example
  • The file name should be undercased and spaces should be underscores about_page.dart
  • When possible use StatelessWidgets
  • Add a route to the app.dart file (iirc) in order to navigate to that screen
  • Have fun!

@Vanethos
Copy link
Contributor Author

Vanethos commented Oct 8, 2019

@Thesmader The text for this screen will be added in a few minutes.

I'll assign this issue to you

@Thesmader
Copy link
Contributor

Thank you, @Vanethos. I will start working on it.

@Thesmader
Copy link
Contributor

I'm done with the basic parts of the screen. I will need the image and content to complete the work.

@Vanethos
Copy link
Contributor Author

@Thesmader
The text is in the first post.

As for the image, could you please put a placeholder?

Additionally, we are waiting for the contacts information, so please setup the layouts with mock data assuming that you are receiving data objects with the format given in the issue

@Thesmader
Copy link
Contributor

Alright, I'll do that.

@Vanethos
Copy link
Contributor Author

@Thesmader any news on the PR?

@Thesmader
Copy link
Contributor

Thesmader commented Oct 15, 2019

Sorry for the delay. I was busy with my classes. I am almost done with the work. Will open the PR soon.

@Thesmader
Copy link
Contributor

This was my first Hacktoberfest. Thank you for letting me work on this repo. I learned to write good code by seeing the code in this repo. It was a lovely experience for me.

@Vanethos
Copy link
Contributor Author

Thank you so much @Thesmader your comment surely made my week! :D

Anytime you want to contribute to this or other projects, please do let me know! You can ping me at https://twitter.com/GonPalma !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these! Needs Maintainers Help The maintainer is needed for something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants