Merge pull request #404 from DolbyIO/unknown_track_warning_11

Warn if the video track ID is suspicious
voxeet · Sep 12, 2023 · cb386de · cb386de
2 parents c9666fd + d2298f3
commit cb386de
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/DolbyIO/Source/Private/DolbyIOSubsystem.cpp b/DolbyIO/Source/Private/DolbyIOSubsystem.cpp
@@ -219,6 +219,7 @@ void UDolbyIOSubsystem::Initialize(const FString& Token)
 			            const FDolbyIOVideoTrack VideoTrack = ToFDolbyIOVideoTrack(Event.track);
 			            DLB_UE_LOG("Video track removed: TrackID=%s ParticipantID=%s", *VideoTrack.TrackID,
 			                       *VideoTrack.ParticipantID);
+			            WarnIfVideoTrackSuspicious(VideoTrack.TrackID);
 
 			            FScopeLock Lock{&VideoSinksLock};
 			            if (std::shared_ptr<DolbyIO::FVideoSink>* Sink = VideoSinks.Find(VideoTrack.TrackID))
@@ -632,9 +633,18 @@ void UDolbyIOSubsystem::DisableVideo()
 void UDolbyIOSubsystem::BroadcastVideoTrackAdded(const FDolbyIOVideoTrack& VideoTrack)
 {
 	DLB_UE_LOG("Video track added: TrackID=%s ParticipantID=%s", *VideoTrack.TrackID, *VideoTrack.ParticipantID);
+	WarnIfVideoTrackSuspicious(VideoTrack.TrackID);
 	BroadcastEvent(OnVideoTrackAdded, VideoTrack);
 }
 
+void UDolbyIOSubsystem::WarnIfVideoTrackSuspicious(const FString& VideoTrackID)
+{
+	if (VideoTrackID == "{-}")
+	{
+		DLB_UE_WARN("Suspicious video track ID added, things may not work as expected");
+	}
+}
+
 void UDolbyIOSubsystem::BroadcastVideoTrackEnabled(const FDolbyIOVideoTrack& VideoTrack)
 {
 	DLB_UE_LOG("Video track enabled: TrackID=%s ParticipantID=%s", *VideoTrack.TrackID, *VideoTrack.ParticipantID);

diff --git a/DolbyIO/Source/Public/DolbyIOSubsystem.h b/DolbyIO/Source/Public/DolbyIOSubsystem.h
@@ -442,6 +442,7 @@ class DOLBYIO_API UDolbyIOSubsystem : public UGameInstanceSubsystem
 	void BroadcastVideoTrackAdded(const FDolbyIOVideoTrack& VideoTrack);
 	void BroadcastVideoTrackEnabled(const FDolbyIOVideoTrack& VideoTrack);
 	void ProcessBufferedVideoTracks(const FString& ParticipantID);
+	void WarnIfVideoTrackSuspicious(const FString& VideoTrackID);
 
 	void SetLocationUsingFirstPlayer();
 	void SetLocalPlayerLocationImpl(const FVector& Location);