Fake images #71
Open
Fake images #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobmarks
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Should be a separate PR
jacobmarks
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Upload as raw github user content or google drive and add via URL or download, to avoid bloat in repo. Same goes for all images.
jacobmarks
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Add the tracking stuff as a separate PR
jacobmarks
reviewed
Nov 14, 2023
There was a problem hiding this comment.
separate out the tracking stuff
jacobmarks
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Feedback on the notebook:
- instead of
for sample in dataset, usedataset.iter_samples(autosave=True)— it's faster - We have access to
filenameassample.filename. You don't needos.pathhere - make sure all images of the app are actually viewable, not blank or pixelating. Add as separate images like the butterflies
- For SD images, maybe use the Text-to-Image Plugin, or make a note about it? This would be more robust but achieve the same effect as your tagging with
"diffusion", as well as give transparency into the prompts - Why installing numba? It should be installed by default, right?
- for
compute_visualization(),num_dims=2is default,"emb"is not a descriptive key, andverbose=Trueisn't helpful if omitting outputs.
high level feedback:
- some motivation and conclusion would be helpful
- if you are using default model for embeddings, you should say what it is. Also probably worth showing a few models and seeing how things look in the dim reduced space, i.e. what each model picks up on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick demo to show how to use embeddings to spot fakes