-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load default view #115
Draft
brimoor
wants to merge
4
commits into
main
Choose a base branch
from
load-default-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Load default view #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
7 tasks
imanjra
previously approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. LGTM
def execute(self, ctx): | ||
default_view = ctx.dataset.info.get("default_view", None) | ||
if default_view and ctx.dataset.has_saved_view(default_view): | ||
if Version(fo.__version__) >= Version("0.23.7"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
brimoor
force-pushed
the
load-default-view
branch
from
April 13, 2024 14:55
bc6675f
to
273ac3c
Compare
brimoor
force-pushed
the
load-default-view
branch
from
August 22, 2024 16:07
273ac3c
to
ad9231d
Compare
brimoor
force-pushed
the
load-default-view
branch
from
September 17, 2024 15:39
ad9231d
to
082f590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
@voxel51/utils/load_default_view
operator that will load a default saved view, if one is registered, whenever datasets are opened in the App.TODO BEFORE MERGING
@voxel51/utils
as we should be sensitive to avoid too many things happeningon_dataset_open
in core plugins...Example usage