fix: escape slash in resource name #101
Draft
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritz-makandra
force-pushed
the
master
branch
4 times, most recently
from
964567a to
4715107
Compare
|
The test are failing, because the changes aren't included in the libraries shipped with the distributions The augeas library needs to be version 1.14.1 which is shipped with Ubuntu 24.04 My change works in our environment since we use puppet 8 which vendors all the required versions to make this work. The tests doesn't work even on Ubuntu 24.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow slashes in the sysctl keys.
This is possible by escaping slashes: hercules-team/augeas#668: Augeas fails to parse properties-files with "/" in property names
This Pull Request (PR) fixes the following issues
Fixes #17
Fixes #66
Fixes voxpupuli/puppet-augeasproviders#102: sysctl doesn't work for keys that contain slash, e.g. VLANs