Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Puppet 8 support #37

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add Puppet 8 support #37

merged 1 commit into from
Oct 20, 2023

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the enhancement New feature or request label Jul 3, 2023
@bastelfreak bastelfreak self-assigned this Jul 3, 2023
ekohl
ekohl reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why Archlinux fails. Perhaps it's missing some facts? Also quite weird that it fails to load BSD.

@ekohl
Copy link
Member

ekohl commented Jul 4, 2023

It's actually this part: https://github.com/puppetlabs/puppet/blob/c4c07ee6aa088324d9d8612c9fdb1daed75a739d/lib/puppet/provider/service/init.rb#L25-L26
So it suggests the os.name or os.family fact is missing.

@ekohl
Copy link
Member

ekohl commented Jul 4, 2023

puppetlabs/puppet#9082

@jhoblitt
Copy link
Member

rebased on current master.

@jhoblitt jhoblitt merged commit 69fbb51 into master Oct 20, 2023
@jhoblitt jhoblitt deleted the puppet8_20230723 branch October 20, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@jhoblitt jhoblitt jhoblitt approved these changes

Assignees

@bastelfreak bastelfreak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @jhoblitt