Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debian gpg validation and improve rundeck::install spec file #528

Merged
merged 11 commits into from
Jan 24, 2024

Conversation

Joris29
Copy link
Contributor

@Joris29 Joris29 commented Jan 12, 2024

Pull Request (PR) description

This PR will fix the debian gpg validation and will improve the rundeck install spec file

@Joris29 Joris29 changed the title Fix gpg validation and update install spec file Fix debian gpg validation and improve rundeck::install spec file Jan 12, 2024
@Joris29
Copy link
Contributor Author

Joris29 commented Jan 12, 2024

@kenyon I tried with several approaches but it keeps failing any idea why?

@kenyon
Copy link
Member

kenyon commented Jan 12, 2024

Not sure if I'm constructing the URL properly, but this gives a 404: https://packages.rundeck.com/pagerduty/rundeck/any/dists/main/InRelease

@Joris29
Copy link
Contributor Author

Joris29 commented Jan 12, 2024

Are you trying to get the deb package or the gpg key?

@kenyon
Copy link
Member

kenyon commented Jan 12, 2024

Trying to get the InRelease file to manually verify it like curl 'https://deb.debian.org/debian-security/dists/bullseye-security/InRelease' | gpg --verify.

@Joris29
Copy link
Contributor Author

Joris29 commented Jan 12, 2024

script.deb.sh.txt
This is the script that rundeck recommends on using for their deb packages
And this is the url that lists all the packages https://packages.rundeck.com/pagerduty/rundeck

@Joris29 Joris29 force-pushed the Fix_gpg_validation branch 2 times, most recently from f4a0042 to 74d9b08 Compare January 17, 2024 08:29
Reverting to the old ID and keyserver method fixes the gpg validation
@Joris29
Copy link
Contributor Author

Joris29 commented Jan 17, 2024

@kenyon Using the old apt method with ID and keyserver seem to work for most debian tests but not sure what's wrong with the rest of the tests

@Joris29
Copy link
Contributor Author

Joris29 commented Jan 23, 2024

@kenyon I managed to pin down the failing tests to one. Rundeck released a new major version and this is causing some issues so i locked it to two 4.17 version in the unit tests, which seem to resolve most issues.

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you can drop support for Ubuntu 18.04 too, since there isn't a package for it.

spec/classes/install_spec.rb Outdated Show resolved Hide resolved
data/Debian.yaml Outdated Show resolved Hide resolved
data/Debian.yaml Outdated Show resolved Hide resolved
@Joris29
Copy link
Contributor Author

Joris29 commented Jan 24, 2024

@kenyon The issue is resolved by added the raw key content in hiera, it's still strange that source doesn't work then as it is the same key maybe this has to be investigated?

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good solution. Not sure what the problem with the key was, I haven't seen that elsewhere yet.

@kenyon kenyon added bug Something isn't working enhancement New feature or request labels Jan 24, 2024
@kenyon kenyon merged commit 0267d0b into voxpupuli:master Jan 24, 2024
32 checks passed
@Joris29 Joris29 deleted the Fix_gpg_validation branch January 24, 2024 20:24
@bastelfreak bastelfreak removed the enhancement New feature or request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants