-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debian gpg validation and improve rundeck::install spec file #528
Conversation
@kenyon I tried with several approaches but it keeps failing any idea why? |
Not sure if I'm constructing the URL properly, but this gives a 404: https://packages.rundeck.com/pagerduty/rundeck/any/dists/main/InRelease |
Are you trying to get the deb package or the gpg key? |
Trying to get the |
script.deb.sh.txt |
f4a0042
to
74d9b08
Compare
Reverting to the old ID and keyserver method fixes the gpg validation
74d9b08
to
d113e0f
Compare
@kenyon Using the old apt method with ID and keyserver seem to work for most debian tests but not sure what's wrong with the rest of the tests |
@kenyon I managed to pin down the failing tests to one. Rundeck released a new major version and this is causing some issues so i locked it to two 4.17 version in the unit tests, which seem to resolve most issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you can drop support for Ubuntu 18.04 too, since there isn't a package for it.
@kenyon The issue is resolved by added the raw key content in hiera, it's still strange that source doesn't work then as it is the same key maybe this has to be investigated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good solution. Not sure what the problem with the key was, I haven't seen that elsewhere yet.
Pull Request (PR) description
This PR will fix the debian gpg validation and will improve the rundeck install spec file