Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect facts iteratively #152

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Collect facts iteratively #152

merged 1 commit into from
Jul 20, 2023

Commits on Jul 20, 2023

  1. Collect facts iteratively 

    Rather than getting the facts for every filter spec and then discarding
that, this stores the found facts in an array and uses that.

This eliminates a call to FacterDB::get_facts with a very complex
filter.

A quick test in puppet-nginx reduces loading of tests by about 2 seconds
(from ~9 to ~7).
    @ekohl
    ekohl committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    58fa0a4 View commit details
    Browse the repository at this point in the history