Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all test cases before merging into upstream. #45

Closed
tetsuharuohzeki opened this issue Dec 2, 2016 · 3 comments
Closed

Check all test cases before merging into upstream. #45

tetsuharuohzeki opened this issue Dec 2, 2016 · 3 comments

Comments

@tetsuharuohzeki
Copy link
Contributor

The status of mergeablity of GitHub's pull request only checks code's mergeability. But this is not reliable approach because there are some case that can merge codes but fails testing or build.

To achieve more reliability, this bot should check all test cases before merging into upstream.

Other issues.

Block https://github.com/nekoya/popuko/issues/27

@tetsuharuohzeki
Copy link
Contributor Author

We would need:

  • Collaboration with CI (pluggable)
    • we should add the config to use this feature.
  • sqlite or other db to manage an inbound queue.

@tetsuharuohzeki
Copy link
Contributor Author

note:

As my guess, we would be able to implement this feature

  1. by status event,
  2. and checking sha
  3. and checking the branch name.

So we would need to store the sha of the tip of the auto branch.

@tetsuharuohzeki
Copy link
Contributor Author

This feature is almost implemented. We can dogfooding now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant