Optimize screenshare page initialization and handling

vpalmisano · Feb 6, 2025 · d0b4a00 · d0b4a00
1 parent 01c813b
commit d0b4a00
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/src/session.ts b/src/session.ts
@@ -1343,22 +1343,18 @@ webrtcperf.VIDEO_URL = "http${this.serverUseHttps ? 's' : ''}://localhost:${this
       let screensharePage = page
       if (!this.useFakeMedia) {
         if (!this.screensharePage) {
-          this.screensharePage = await this.browser.newPage()
+          screensharePage = this.screensharePage = await this.browser.newPage()
           await this.screensharePage.evaluateOnNewDocument(this.setupPageCmd(index, tabIndex, 'about:blank'))
           for (const name of ['scripts/common.js', 'scripts/screenshare.js']) {
             await this.screensharePage.evaluateOnNewDocument(fs.readFileSync(resolvePackagePath(name), 'utf8'))
           }
-          await this.screensharePage.exposeFunction(
-            'keypressText',
-            async (selector: string, text: string, delay = 20) => {
-              await page.type(selector, text, { delay })
-            },
-          )
-          await this.screensharePage.goto(
+          await screensharePage.exposeFunction('keypressText', async (selector: string, text: string, delay = 20) => {
+            await screensharePage.type(selector, text, { delay })
+          })
+          await screensharePage.goto(
             `http${this.serverUseHttps ? 's' : ''}://localhost:${this.serverPort}/empty-page?auth=${this.serverSecret}&title=webrtcperf-screenshare`,
           )
         }
-        screensharePage = this.screensharePage
       } else if (this.getDisplayMediaType === 'monitor') {
         return
       }