python/roman-numerals: 3rd iteration - py3.11

vpayno · Apr 13, 2024 · 69f9b93 · 69f9b93
1 parent 2985a23
commit 69f9b93
Show file tree

Hide file tree

Showing 5 changed files with 125 additions and 115 deletions.
diff --git a/python/roman-numerals/.coverage b/python/roman-numerals/.coverage
@@ -1 +1 @@
-!coverage.py: This is a private format, don't read it directly!{"arcs":{"/home/vpayno/git_vpayno/exercism-workspace/python/roman-numerals/test/__init__.py":[[0,0],[0,-1]],"/home/vpayno/git_vpayno/exercism-workspace/python/roman-numerals/roman_numerals.py":[[0,1],[1,3],[3,5],[5,6],[6,7],[7,10],[10,-1],[10,11],[11,13],[13,14],[14,15],[15,16],[16,17],[17,18],[18,19],[19,20],[20,21],[21,22],[22,23],[23,24],[24,25],[25,26],[26,28],[28,29],[29,30],[30,31],[31,29],[29,28],[28,33],[33,-10]]}}
+!coverage.py: This is a private format, don't read it directly!{"arcs":{"/home/vpayno/git_vpayno/exercism-workspace/python/roman-numerals/test/__init__.py":[[0,0],[0,-1]],"/home/vpayno/git_vpayno/exercism-workspace/python/roman-numerals/roman_numerals.py":[[0,1],[1,3],[3,5],[5,6],[6,7],[7,10],[10,-1],[10,17],[17,19],[19,20],[20,21],[21,22],[22,23],[23,24],[24,25],[25,26],[26,27],[27,28],[28,29],[29,30],[30,31],[31,32],[32,34],[34,35],[35,36],[36,37],[37,35],[35,34],[34,39],[39,-10]]}}
diff --git a/python/roman-numerals/.coverage.xml b/python/roman-numerals/.coverage.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" ?>
-<coverage branch-rate="1" branches-covered="4" branches-valid="4" complexity="0" line-rate="0.9615" lines-covered="25" lines-valid="26" timestamp="1713023160375" version="4.5.4">
+<coverage branch-rate="1" branches-covered="4" branches-valid="4" complexity="0" line-rate="0.9615" lines-covered="25" lines-valid="26" timestamp="1713023346262" version="4.5.4">
 	<!-- Generated by coverage.py: https://coverage.readthedocs.io -->
 	<!-- Based on https://raw.githubusercontent.com/cobertura/web/master/htdocs/xml/coverage-04.dtd -->
 	<sources>
@@ -17,13 +17,7 @@
 						<line hits="1" number="6"/>
 						<line hits="1" number="7"/>
 						<line hits="1" number="10"/>
-						<line hits="1" number="11"/>
-						<line hits="1" number="13"/>
-						<line hits="1" number="14"/>
-						<line hits="1" number="15"/>
-						<line hits="1" number="16"/>
 						<line hits="1" number="17"/>
-						<line hits="1" number="18"/>
 						<line hits="1" number="19"/>
 						<line hits="1" number="20"/>
 						<line hits="1" number="21"/>
@@ -32,11 +26,17 @@
 						<line hits="1" number="24"/>
 						<line hits="1" number="25"/>
 						<line hits="1" number="26"/>
-						<line branch="true" condition-coverage="100% (2/2)" hits="1" number="28"/>
-						<line branch="true" condition-coverage="100% (2/2)" hits="1" number="29"/>
+						<line hits="1" number="27"/>
+						<line hits="1" number="28"/>
+						<line hits="1" number="29"/>
 						<line hits="1" number="30"/>
 						<line hits="1" number="31"/>
-						<line hits="1" number="33"/>
+						<line hits="1" number="32"/>
+						<line branch="true" condition-coverage="100% (2/2)" hits="1" number="34"/>
+						<line branch="true" condition-coverage="100% (2/2)" hits="1" number="35"/>
+						<line hits="1" number="36"/>
+						<line hits="1" number="37"/>
+						<line hits="1" number="39"/>
 					</lines>
 				</class>
 			</classes>

diff --git a/python/roman-numerals/roman_numerals.py b/python/roman-numerals/roman_numerals.py
@@ -8,6 +8,12 @@
 
 
 def roman(number: ModernNumeralT) -> RomanNumeralT:
+    """Convert a decimal number to a roman numeral.
+
+    :param number: integer
+    :return: string
+    """
+
     rn: RomanNumeralT = ""
 
     d2r: MapD2RT = OrderedDict()

diff --git a/python/roman-numerals/roman_numerals.py,cover b/python/roman-numerals/roman_numerals.py,cover
@@ -8,6 +8,12 @@
 
 
 > def roman(number: ModernNumeralT) -> RomanNumeralT:
+>     """Convert a decimal number to a roman numeral.
+
+>     :param number: integer
+>     :return: string
+>     """
+
 >     rn: RomanNumeralT = ""
 
 >     d2r: MapD2RT = OrderedDict()
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		!coverage.py: This is a private format, don't read it directly!{"arcs":{"/home/vpayno/git_vpayno/exercism-workspace/python/roman-numerals/test/__init__.py":[[0,0],[0,-1]],"/home/vpayno/git_vpayno/exercism-workspace/python/roman-numerals/roman_numerals.py":[[0,1],[1,3],[3,5],[5,6],[6,7],[7,10],[10,-1],[10,11],[11,13],[13,14],[14,15],[15,16],[16,17],[17,18],[18,19],[19,20],[20,21],[21,22],[22,23],[23,24],[24,25],[25,26],[26,28],[28,29],[29,30],[30,31],[31,29],[29,28],[28,33],[33,-10]]}}
		!coverage.py: This is a private format, don't read it directly!{"arcs":{"/home/vpayno/git_vpayno/exercism-workspace/python/roman-numerals/test/__init__.py":[[0,0],[0,-1]],"/home/vpayno/git_vpayno/exercism-workspace/python/roman-numerals/roman_numerals.py":[[0,1],[1,3],[3,5],[5,6],[6,7],[7,10],[10,-1],[10,17],[17,19],[19,20],[20,21],[21,22],[22,23],[23,24],[24,25],[25,26],[26,27],[27,28],[28,29],[29,30],[30,31],[31,32],[32,34],[34,35],[35,36],[36,37],[37,35],[35,34],[34,39],[39,-10]]}}