Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #3

Open
vulpivia opened this issue Dec 30, 2019 · 3 comments
Open

Versioning #3

vulpivia opened this issue Dec 30, 2019 · 3 comments

Comments

@vulpivia
Copy link
Contributor

How is versioning handled? If I understood the code right, the "update" command always updates to the most current commit in a repository.

If that's the case, wouldn't it make more sense to get the repository at the commit in which the version number has been changed or something like that? A new version would then be created when the version number in vpkg.json changes.

@nedpals
Copy link
Collaborator

nedpals commented Dec 30, 2019

Thats the purpose of tags in git. vpkg does indicate both the version indicated in the vpkg.json/v.mod and the commit hash at the end of installation but I have yet to add a mechanism in specifying the version of the packages through git tags.

@vulpivia
Copy link
Contributor Author

vpkg does indicate both the version indicated in the vpkg.json/v.mod and the commit hash at the end of installation

What does indicate mean in that context? That it's only used to show the user which version was installed?

When versions are specified using git tags, will the version number become obsolete? I might look into how we can use git tags if I find the time in the next few days.

@nedpals
Copy link
Collaborator

nedpals commented Dec 31, 2019

What does indicate mean in that context? That it's only used to show the user which version was installed?

Yes. But I also forgot to mention that both the commit hash and version listed at the package manifest is also recorded to the lockfile.

When versions are specified using git tags, will the version number become obsolete? I might look into how we can use git tags if I find the time in the next few days.

It won't. Git tags aren't the best way to do versioning and version numbers indicated at the manifest will remain for double-checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants