Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorcoded items background causing highlighting issues #32

Open
Sawtaytoes opened this issue Oct 29, 2014 · 4 comments
Open

Colorcoded items background causing highlighting issues #32

Sawtaytoes opened this issue Oct 29, 2014 · 4 comments

Comments

@Sawtaytoes
Copy link

When doing an outline on text like if I'm in a find operation, the outline does not go around the colorcoded items because they have a background color that matches the unhighlighted background color of the syntax method.

Is it possible to make it so colorcoded items don't have this background color?

@vprimachenko
Copy link
Owner

no. current api does not allow it or to be precise setting the background color is the only way to color only the text*. without this "hack" colorcoder would look like this:

colorcoder-no-bg

i am actually frustrated by this as well, as this limitation also interferes with current line-highlighting. i even tried to work around this issues yet the only way i could think of introduced massive lag to the editor so i never pushed it to master.

so as much as i would love to implement this now, i cant… i check the api of every release and will implement this as soon as the api allows.

im not sure if i should close this issue as an "cant-fix" or keep it open 'till the fix arrives.

* for whatever reason if an region class does not have an background setting, its foreground is used to fill the background, and the text keeps it color. interestingly enough sublime also does this if background matches the overall theme background. i am puzzled why sublime works this way.

@Sawtaytoes
Copy link
Author

Darn, that's a good point. Seems like an awfully strange limitation; then again, ST3 has some other long-standing bugs at this time too :/. Sad.

@Sawtaytoes
Copy link
Author

Is it possible to manually fix this in the modified (Colorcoded).tmTheme files?

@vprimachenko
Copy link
Owner

dont think so, i tried a lot of promising combinations of findHighlight and findHighlightForeground values yet nothing satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants