-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conflicts with color highlighter #49
Comments
@rocketinventor: what package are you talking about? what is the URL of this issue? |
@dungsaga the url of the issue ishttps://github.com/Monnoroch/ColorHighlighter/issues/218 |
There will be conflicts when multiple plugins modify the color scheme. |
@dungsaga Basically, if both plugins are installed, it should be possible to only use one event listener for user color scheme change and on edit events. When this listener is activated the two plugins color scheme modifiers will be ran once and, sequentially. The coordination could also be done by a separate plugin. When installed, it would make sure any automatic color scheme changers were set to manual only and then would create the listener and run the plugins in alphabetic or user chosen order. This of course would only work given that both plugins have an external function that will run its color scheme modifier. At the very least, for the time being, some color scheme name logic should be added. If a color scheme has a name like blue x'd y'd x'd y'd x'd y'd x'd y'd x'd then one or both plugins should disable themselves and alert the user that there is conflict. |
This package conflicts with color highlighter.
I have already submitted an issue on its' Github page. If there is any sort of possible workaround then, let's do it, otherwise, let's make sure to add to the readme that they are incompatible.
For more details, see the commit on that page.
The text was updated successfully, but these errors were encountered: