Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Github-hosted package causes the listing creation job to fail with a useless error message #10

Open
FairlySadPanda opened this issue May 10, 2023 · 2 comments

Comments

@FairlySadPanda
Copy link

FairlySadPanda commented May 10, 2023

Summary
Even when following the VRC-recommended package setup steps, using the provided in-Editor tool, our trivial VRCBCE2 project crashes the list creation job.

Steps to reproduce

  1. Create a new VCC repo
  2. Add a newly created Github-hosted package to the githubRepos array in the repo's source.json file. The package must not have a release on Github.
  3. Commit the change and wait for the Github Action to complete.

Expected outcome
The Action concludes without error.

Actual outcome
The list building job will throw the following exception:

System.ArgumentNullException: Value cannot be null. (Parameter 'collection')
     at System.Collections.Generic.List`1.InsertRange(Int32 index, IEnumerable`1 collection)
     at System.Collections.Generic.List`1.AddRange(IEnumerable`1 collection)
     at VRC.PackageManagement.Automation.Build.<get_BuildRepoListing>b__24_1() in /home/runner/work/vcc-repo/vcc-repo/ci/PackageBuilder/Build.cs:line 166
     at Nuke.Common.Execution.TargetDefinition.<>c__DisplayClass77_0.<Executes>b__0() in /_/source/Nuke.Common/Execution/TargetDefinition.cs:line 71
     at Nuke.Common.Execution.BuildExecutor.<>c.<Execute>b__4_2(Action x) in /_/source/Nuke.Common/Execution/BuildExecutor.cs:line 112
     at Nuke.Common.Utilities.Collections.EnumerableExtensions.ForEach[T](IEnumerable`1 enumerable, Action`1 action) in /_/source/Nuke.Common/Utilities/Collections/Enumerable.ForEach.cs:line 17
     at Nuke.Common.Execution.BuildExecutor.Execute(NukeBuild build, ExecutableTarget target, IReadOnlyCollection`1 previouslyExecutedTargets, Boolean failureMode) in /_/source/Nuke.Common/Execution/BuildExecutor.cs:line 112

Additional information
This will not occur if the repo has had a release.

@FairlySadPanda
Copy link
Author

FairlySadPanda commented May 10, 2023

Other minor complaint: the action doesn't support the act testing tool, reporting ci/build.cmd: line 3: /mnt/f/VRChat: No such file or directory during the building job.

Being forced to use Actions remotely to test and debug is a time-consuming effort, especially as Actions endures frequent outages.

@FairlySadPanda FairlySadPanda changed the title Invalid Github repositories will cause the build-listing job to fail with a useless error message New Github-hosted package causes the listing creation job to fail with a useless error message May 11, 2023
@FairlySadPanda
Copy link
Author

I've updated this ticket with the bug format I usually follow and a clearer bug to report. This is adjacent to issue #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant