New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item aliases property is currently null #19

Open

vreddi opened this issue Sep 19, 2017 · 0 comments

Assignees

Labels

bug

Owner

vreddi commented Sep 19, 2017

We have 2 options here:
Either temporarily we remove the aliases property from the data object or we find a way to populate that property.

Since this information is not available for scraping we need a way to build aliases:

Abbreviation creator component? -> to handle abbreviations
Adv: Can be re-used for Heros
Dis: May not be accurate
Hard-coded list?
Adv: The list will never go obsolete (exception -> when new items are added to the game)
Dis: Increases unnecessary size to the code-base.

vreddi added the bug label

vreddi self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment