Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker: keep window size #180

Closed
qm210 opened this issue Nov 9, 2024 · 3 comments
Closed

tracker: keep window size #180

qm210 opened this issue Nov 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@qm210
Copy link
Contributor

qm210 commented Nov 9, 2024

is probably a short fix that I can also do one of these days, but just to get it out of my head:

during testing, I get somewhat tired of always having to resize the fresh window. could store the resolution somewhere instead of defaulting to 800x600

@vsariola vsariola added the enhancement New feature or request label Nov 10, 2024
@vsariola
Copy link
Owner

There is a subtlety here which is a bit of a bigger refactoring, but not much: currently, modelData is the state of the tracker that is a) rewinded backwards when you undo; b) saved to the recovery file.

I think a) and b) should be different things. Or more specifically, b) should be a larger struct & contain a) as its part. And the window size should be part of b), but not a) (we don't want to undo window resizing).

I think there's a couple of other things too that could be b), like instrEnlarged and commentExpanded etc. Perhaps even the positions of the splits (the bars that you can drag to rescale different parts of the window) should be there, so that we recall as much as possible of how things are laid out when you restart Sointu.

@vsariola
Copy link
Owner

Changing the recovery file structure is a bit nasty, but that's why we are not yet at v1.0 so that we can break these things freely. But if it's possible to make it so that old recovery files are still read correctly, that would be great.

@vsariola
Copy link
Owner

vsariola commented Dec 7, 2024

I think this does not play that well with the idea of #184 / #185: if the user has saved a recovery file, do we load the previous window size from the recovery file or the Preferences? So let's stick to the approach taken in #185 i.e. always just honor the preferences. Thus, this can be closed.

@vsariola vsariola closed this as completed Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants