Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values to styles #164

Open
veredcon opened this issue Sep 23, 2024 · 3 comments
Open

Add default values to styles #164

veredcon opened this issue Sep 23, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@veredcon
Copy link

In the original webview toolkit there were default styles configured in case no VSCode variable is present.
for example in case of color
This helps in local development when there are no VSCode variables available.. otherwise styles look bad

e.g:
button in local development:
image

button as part of vscode weview:
image

@bendera
Copy link
Member

bendera commented Sep 23, 2024

That's a valid point. Until I add them, you can use these css variables during the development:
https://github.com/vscode-elements/elements/blob/main/dev-assets/dark-v2.txt
This is the default theme called "Dark Modern".

@bendera bendera added the enhancement New feature or request label Sep 23, 2024
@bendera
Copy link
Member

bendera commented Oct 3, 2024

@bendera bendera added the good first issue Good for newcomers label Oct 20, 2024
@bendera
Copy link
Member

bendera commented Oct 20, 2024

To anyone who wants to pick up this task,

This is a chore but easy task. You have to add a fallback value in every place where a --vscode prefixed css variable is used. The default VSCode the is the "Dark Modern". This file contains all the theme variables provided by this theme. Keep in mind that --vscode-editor-font-family and --vscode-font-family are platform dependent, sans-serif and monospace will work well for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants